COMP: Fix comparison of integer expressions of different signedness

Use CastWithRangeCheck to safely convert size_t to int.
InsightSoftwareConsortium · Sep 23, 2022 · a7c26b5 · a7c26b5
1 parent f756a4e
commit a7c26b5
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/Modules/IO/MeshVTK/src/itkVTKPolyDataMeshIO.cxx b/Modules/IO/MeshVTK/src/itkVTKPolyDataMeshIO.cxx
@@ -58,20 +58,18 @@ ReadFloatingPointsAsASCII(std::ifstream &        inputFile,
         {
           return -NumericLimits::infinity();
         }
-        const auto numberOfChars = str.size();
 
-        if (numberOfChars <= std::numeric_limits<int>::max())
-        {
-          constexpr auto                                   double_NaN = std::numeric_limits<double>::quiet_NaN();
-          int                                              processedCharCount{ 0 };
-          const double_conversion::StringToDoubleConverter converter(0, double_NaN, double_NaN, "inf", "nan");
-          const auto                                       conversionResult =
-            converter.StringTo<TFloatingPoint>(str.c_str(), static_cast<int>(numberOfChars), &processedCharCount);
+        const int numberOfChars = Math::CastWithRangeCheck<int>(str.size());
 
-          if (processedCharCount == static_cast<int>(numberOfChars) && !std::isnan(conversionResult))
-          {
-            return conversionResult;
-          }
+        constexpr auto                                   double_NaN = std::numeric_limits<double>::quiet_NaN();
+        int                                              processedCharCount{ 0 };
+        const double_conversion::StringToDoubleConverter converter(0, double_NaN, double_NaN, "inf", "nan");
+        const auto                                       conversionResult =
+          converter.StringTo<TFloatingPoint>(str.c_str(), numberOfChars, &processedCharCount);
+
+        if (processedCharCount == numberOfChars && !std::isnan(conversionResult))
+        {
+          return conversionResult;
         }
       }
       itkGenericExceptionMacro("Failed to read a floating point component from the specified ASCII input file!"