From 10bb07a9d0ca872c23d934ae17f8e2a4b191a074 Mon Sep 17 00:00:00 2001 From: I569349 Date: Fri, 13 Oct 2023 15:00:26 +0200 Subject: [PATCH] Modified changelog Added entry to changelog Removed unused imports from uTests --- CHANGELOG.md | 1 + .../org/jabref/logic/integrity/TitleCheckerTest.java | 9 ++++++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 627167f4fc0..3b537759ac7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,6 +30,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We modified the DOI cleanup to infer the DOI from an ArXiV ID if it's present. [#10426](https://github.com/JabRef/jabref/issues/10426) - The ISI importer uses the field `comment` for notes (instead of `review). [#10478](https://github.com/JabRef/jabref/pull/10478) - If no existing document is selected for exporting "Embedded BibTeX pdf" JabRef will now create a new PDF file with a sample text and the metadata. [#10101](https://github.com/JabRef/jabref/issues/10101) +- Translated titles format no longer raise a warning. [#10459](https://github.com/JabRef/jabref/issues/10459) ### Fixed diff --git a/src/test/java/org/jabref/logic/integrity/TitleCheckerTest.java b/src/test/java/org/jabref/logic/integrity/TitleCheckerTest.java index 6ca0b4fe98a..1d590f9108d 100644 --- a/src/test/java/org/jabref/logic/integrity/TitleCheckerTest.java +++ b/src/test/java/org/jabref/logic/integrity/TitleCheckerTest.java @@ -8,8 +8,6 @@ import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Nested; import org.junit.jupiter.api.Test; -import org.junit.jupiter.params.ParameterizedTest; -import org.junit.jupiter.params.provider.ValueSource; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotEquals; @@ -204,7 +202,12 @@ void bibTexAcceptsCapitalLetterOnlyAfterSpecialCharacter() { void bibTexAcceptsOriginalAndTranslatedTitle() { String title = "This is a title [This is translated title]"; assertEquals(Optional.empty(), checker.checkValue(title)); - assertEquals(Optional.empty(), checker.checkValue(translatedTitle(title))); + } + + @Test + void bibTexNotAcceptsLeadingTranslatedTitleWithOriginal() { + String title = "[This is translated title] This is a title"; + assertNotEquals(Optional.empty(), checker.checkValue(title)); } private String translatedTitle(String title) {