From 2e5be6d1f7b550118ac7a95ca1b84567cf121d36 Mon Sep 17 00:00:00 2001 From: Stefan Kolb Date: Tue, 19 Apr 2016 18:29:17 +0200 Subject: [PATCH 1/3] Fixes #1234 Trigger entry update explicitly --- .../net/sf/jabref/gui/entryeditor/FieldExtraComponents.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main/java/net/sf/jabref/gui/entryeditor/FieldExtraComponents.java b/src/main/java/net/sf/jabref/gui/entryeditor/FieldExtraComponents.java index 4377da04696..36cc5d1ad52 100644 --- a/src/main/java/net/sf/jabref/gui/entryeditor/FieldExtraComponents.java +++ b/src/main/java/net/sf/jabref/gui/entryeditor/FieldExtraComponents.java @@ -190,7 +190,9 @@ public static Optional getDoiExtraComponent(BasePanel panel, EntryEd Optional doi = CrossRef.findDOI(entryEditor.getEntry()); if (doi.isPresent()) { JTextComponent field = (JTextComponent) fieldEditor.getTextComponent(); + // set new data field.setText(doi.get().getDOI()); + entryEditor.updateField(fieldEditor); } else { panel.frame().setStatus(Localization.lang("No DOI found")); } From 8ea120285088aa866a230542f025984253d66469 Mon Sep 17 00:00:00 2001 From: Stefan Kolb Date: Tue, 19 Apr 2016 18:48:06 +0200 Subject: [PATCH 2/3] Changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 95dd0125f57..2fcf254f3ae 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,7 @@ to [sourceforge feature requests](https://sourceforge.net/p/jabref/features/) by - Implemented [#1233](https://github.com/JabRef/jabref/issues/1233): Group side pane now takes up all the remaining space ### Fixed +- Fixed [#1234](https://github.com/JabRef/jabref/issues/1234): NPE when getting information from retrieved DOI ### Removed From 5e1ce66f56a3e35310e62465c16798fc93601a3b Mon Sep 17 00:00:00 2001 From: Stefan Kolb Date: Tue, 19 Apr 2016 19:55:50 +0200 Subject: [PATCH 3/3] Directly set the value on the entry and hope for a good event propagation... --- .../net/sf/jabref/gui/entryeditor/FieldExtraComponents.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/main/java/net/sf/jabref/gui/entryeditor/FieldExtraComponents.java b/src/main/java/net/sf/jabref/gui/entryeditor/FieldExtraComponents.java index 36cc5d1ad52..765d9df766a 100644 --- a/src/main/java/net/sf/jabref/gui/entryeditor/FieldExtraComponents.java +++ b/src/main/java/net/sf/jabref/gui/entryeditor/FieldExtraComponents.java @@ -189,10 +189,7 @@ public static Optional getDoiExtraComponent(BasePanel panel, EntryEd doiButton.addActionListener(actionEvent -> { Optional doi = CrossRef.findDOI(entryEditor.getEntry()); if (doi.isPresent()) { - JTextComponent field = (JTextComponent) fieldEditor.getTextComponent(); - // set new data - field.setText(doi.get().getDOI()); - entryEditor.updateField(fieldEditor); + entryEditor.getEntry().setField("doi", doi.get().getDOI()); } else { panel.frame().setStatus(Localization.lang("No DOI found")); }