Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to clear recent libraries #10003

Closed
HoussemNasri opened this issue Jun 11, 2023 · 6 comments · Fixed by #10027
Closed

Add the option to clear recent libraries #10003

HoussemNasri opened this issue Jun 11, 2023 · 6 comments · Fixed by #10027
Assignees
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@HoussemNasri
Copy link
Member

HoussemNasri commented Jun 11, 2023

In the File > Recent libraries menu, it would be appropriate to provide, at the end of the list, the command “Clear Recent libraries,” as below

image

-- Posted by @Mattero339 in the discourse forum

@HoussemNasri HoussemNasri added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Jun 11, 2023
@dkokkotas
Copy link
Contributor

hello @HoussemNasri, I would like to work on that.

@HoussemNasri
Copy link
Member Author

Hi @demetres12, please make sure to get it as in the screenshot. There should be a menu separator between the recent libraries and the "Clear recent libraries" menu item.

@dkokkotas
Copy link
Contributor

dkokkotas commented Jun 15, 2023

@HoussemNasri As I see there is not a corresponding test class for the FileHistoryMenu class. So, do you think it's better to consider GUI testing in reference to that?

@HoussemNasri
Copy link
Member Author

I don't think it will be necessary. You can write a regular unit test that verifies that the list of recent files is empty after recent files are cleared.

@dkokkotas
Copy link
Contributor

dkokkotas commented Jun 22, 2023

Hello @HoussemNasri , just to keep you updated on my progress. Currently initializing the FileHistoryMenuTest class with the case needed. Will come back to you with a proposed solution.

A question here: Do you think is more proper after clearing the recent libraries,

  • to disable FileHistoryMenu or just
  • clear all menu items (i.e. recent libraries, menu separator and clear option menu item)?

I could go with the first option, as that's the approach followed by other menus and seems more reasonable for the end user

@HoussemNasri
Copy link
Member Author

A question here: Do you think is more proper after clearing the recent libraries,

I like the first approach too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants