Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate library fields after confirmation. Store selected migration preference inside library #10370

Open
koppor opened this issue Sep 11, 2023 · 5 comments

Comments

@koppor
Copy link
Member

koppor commented Sep 11, 2023

I claim: If one opens a .bib file with JabRef, save it and close it, the file is not modified

However, JabRef migrates the field review to comment without any user information. This should not happen.

Proposal:

  1. In case JabRef wants to do a migration, then it asks for the user (example: pdf field)
  2. The answer to the migration choice should be stored in the library

Note on 1: A list of migrations to be performed would be nice. The user can then add and remove migrations on demand.

Links:

@koppor
Copy link
Member Author

koppor commented Oct 7, 2023

As far as I remember, the decision to automatically migrate review was done, because our check in 2015 revealed that review was a custom JabRef field and not used by any other software. We also wanted to streamline the code and support only the latest release version of JabRef.

@koppor
Copy link
Member Author

koppor commented Oct 10, 2023

Code:

and

private static void performLoadDatabaseMigrations(ParserResult parserResult,

@koppor
Copy link
Member Author

koppor commented Nov 8, 2023

Implementation hints were given at #3658 (comment). Follow-up at #3733.

@koppor
Copy link
Member Author

koppor commented Apr 17, 2024

Code merging the fields at org.jabref.migrations.MergeReviewIntoCommentMigration.

@koppor
Copy link
Member Author

koppor commented Aug 26, 2024

Code is in org.jabref.gui.importer.actions.OpenDatabaseAction

    private static final List<GUIPostOpenAction> POST_OPEN_ACTIONS = List.of(
            // Migrations:
            // Warning for migrating the Review into the Comment field
            new MergeReviewIntoCommentAction(),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: High priority
Development

No branches or pull requests

2 participants