Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a quick option to switch skins in the view options under the menu bar #10417

Closed
ehehela opened this issue Sep 26, 2023 · 6 comments
Closed

Comments

@ehehela
Copy link

ehehela commented Sep 26, 2023

It is recommended to add a shortcut option to switch skins in the View menu under the menu bar. This makes it easy for people to switch skins (dark/light mode).

@u7492883
Copy link
Contributor

u7492883 commented Oct 9, 2023

I am interested in working on this issue. Is it free to take?

@u7452206
Copy link

hi,does anyone work on this task? if not, can I take it ?

@ThiloteE
Copy link
Member

I apologize for the late response. I will not yet assign anybody to this issue, until a maintainer that knows more aobut coding than me can clarify.

JabRef currently only allows to change the theme via preferences in the general tab:
image

Shortcut: image.

@calixtus, I do not know, if this is a good first issue, as it seems like in the preferences it is required to select a file via three clicks, so we cannot just copy and paste the existing implementation, but need to come up with something new for the "view" menu.

@u7452206, @u7492883, For now, if you are in a hurry, please have a look at our other good first issues from the projects page. If you have time to wait for clarification, I think the principle of "first come, first served" could be applied here, so that would be u7492883. Usually, we only assign one student, to minimize trouble further down the road.

@calixtus
Copy link
Member

Well, it should not be a bigger problem to add this feature, but the rela question is: Do we want this feature? What sense does this make to quickly switch between different styles? Who really would want this feature? JabRef is a citation management Software, not javafx CSS theme presentation software.

Thanks for your suggestion, but I'm not convinced of the practical advantage of this feature, imho this would add noise to the UI and the view menu.

@calixtus
Copy link
Member

calixtus commented Oct 14, 2023

Maybe a better solution is to automatically select the theme depending of the os general theme and keep the option in the prefs to override this and select a theme manually. See #8729 Keep it simple.

@tobiasdiez
Copy link
Member

I agree with @calixtus. Closing thus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants