Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up operation moves files from file-field to pdf-field and can afterwards no longer be opened directly from JabRef. #4120

Closed
apacha opened this issue Jun 10, 2018 · 6 comments
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs cleanup-ops good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@apacha
Copy link

apacha commented Jun 10, 2018

When I'm cleaning up an entry, the linked PDF is moved from the file={} field to the pdf={} field. Afterwards, it can no longer be opened directly from JabRef:

JabRef version 4.3.1 on Windows 10

Steps to reproduce:

  1. Create entry

  2. Link file

2018-06-10 21_31_41-jabref - c__users_alex_repositories_omr-agenda_docear_omr-agenda bib bibtex mod

  1. Clean up entry

2018-06-10 21_31_58-jabref - c__users_alex_repositories_omr-agenda_docear_omr-agenda bib bibtex mod

  1. Icon to open file from JabRef is gone (the small icon in the table view).

2018-06-10 21_32_05-jabref - c__users_alex_repositories_omr-agenda_docear_omr-agenda bib_ bibtex mo

@apacha apacha changed the title Files are moved to pdf field and are later on no longer found by JabRef Clean-up operation moves files from file-field to pdf-field and can afterwards no longer be opened directly from JabRef. Jun 10, 2018
@apacha
Copy link
Author

apacha commented Jun 10, 2018

Oh. Found the solution - "Upgrade external files to use the file field".

2018-06-10 21_39_53-cleanup entries

@apacha apacha closed this as completed Jun 10, 2018
@Siedlerchr
Copy link
Member

Just out of curiosity, a normal cleanup should not move the file from the file field to the pdf field - even if you don't check the box. It could be a potential bug you have discovered, but I am not sure.
I see you have the convert to bibtex enabled. @koppor Do you know if the bibtex conversion does this or if this is intended?

@tobiasdiez tobiasdiez reopened this Jun 10, 2018
@tobiasdiez tobiasdiez added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Jun 10, 2018
@apacha
Copy link
Author

apacha commented Jun 11, 2018

Just discovered an additional (potential) bug, that is related to this: When cleaning up multiple files with the "Convert to BibTex" option enabled, only the first selected item gets converted, instead of all selected items.

@koppor
Copy link
Member

koppor commented Jun 11, 2018

@apacha Could you copy and paste the bibtex entry here as comment? Use three backticks before and after to make it even more easier to follow.

@Siedlerchr I have no clue and it should not happen, because we got rid of the PDF field looong time ago. - Refs #251 and probably #98, #1052 and #865

@apacha
Copy link
Author

apacha commented Jun 12, 2018

@koppor here you go. It's nothing special.

@InProceedings{Pacha2018,
  author    = {Alexander Pacha and Kwon-Young Choi and Bertrand Co{\"{u}}asnon and Yann Ricquebourg and Richard Zanibbi and Horst Eidenberger},
  title     = {Handwritten Music Object Detection: Open Issues and Baseline Results},
  booktitle = {2018 13th IAPR Workshop on Document Analysis Systems (DAS)},
  year      = {2018},
  file      = {:2018 - Handwritten Music Object Detection - Open Issues and Baseline Results.pdf:PDF},
}

with
2018-06-12 14_29_26-cleanup entries

makes it into

@InProceedings{Pacha2018,
  author    = {Alexander Pacha and Kwon-Young Choi and Bertrand Co{\"{u}}asnon and Yann Ricquebourg and Richard Zanibbi and Horst Eidenberger},
  title     = {Handwritten Music Object Detection: Open Issues and Baseline Results},
  booktitle = {2018 13th IAPR Workshop on Document Analysis Systems (DAS)},
  year      = {2018},
  pdf       = {:2018 - Handwritten Music Object Detection - Open Issues and Baseline Results.pdf:PDF},
}

@Siedlerchr
Copy link
Member

Okay, I could reproduce this with the convert to bibtex cleanup. Definitively a bug

@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs cleanup-ops good first issue An issue intended for project-newcomers. Varies in difficulty. and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Jun 12, 2018
@Siedlerchr Siedlerchr self-assigned this Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs cleanup-ops good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
None yet
Development

No branches or pull requests

4 participants