Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for unlinked local files: "collapse all" button expands tree #6848

Closed
1 task done
mlep opened this issue Sep 2, 2020 · 7 comments · Fixed by #6993
Closed
1 task done

Search for unlinked local files: "collapse all" button expands tree #6848

mlep opened this issue Sep 2, 2020 · 7 comments · Fixed by #6993
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@mlep
Copy link
Contributor

mlep commented Sep 2, 2020

JabRef 5.2--2020-09-02--5c9edc9
Linux 4.9.0-13-amd64 amd64
Java 14.0.2

In the window "Search for unlinked local files", after scanning the directory, a click on "Collapse all" does not collapse the tree. But this button can be used to expand the tree.

Steps to reproduce the behavior:

  1. Lookup -> Search for unlinked local files
  2. scan directory
  3. click on "Collapse all". Nothing happens.
  4. collapse the tree manually by clicking on the triangle at the root.
  5. click on "Collapse all". The tree is expanded.

The "Collapse all" button works the same way as the "Expand all" button.

@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. ui labels Sep 2, 2020
@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Sep 2, 2020
@PremKolar
Copy link
Contributor

Hi, I would like to try to fix this as my first issue :)

@PremKolar
Copy link
Contributor

PremKolar commented Sep 4, 2020

I think there is no bug actually..
When you hit Collapse all, every directory except the root one gets collapsed. Expand all, expands all...
I think it makes sense and works well.. There is no use of collapsing the root level.

@mlep
Copy link
Contributor Author

mlep commented Sep 4, 2020

@PremKolar Well, maybe the issue is limited to:
When everything is collapsed (only the root directory is shown), "Collapse all" should not expand the tree.

@skeric
Copy link
Contributor

skeric commented Oct 9, 2020

Hi, I would like to work on that issue.

@Siedlerchr
Copy link
Member

Thanks to @skeric this issue should now be fixed

@mlep
Copy link
Contributor Author

mlep commented Oct 13, 2020

It works now! Thank you @skeric!

@skeric
Copy link
Contributor

skeric commented Oct 13, 2020

@Siedlerchr and @mlep, you're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants