Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Menu: "Attach File from URL" / "Download File from URL" #9646

Closed
bf opened this issue Mar 4, 2023 · 3 comments · Fixed by #9648
Closed

Context Menu: "Attach File from URL" / "Download File from URL" #9646

bf opened this issue Mar 4, 2023 · 3 comments · Fixed by #9648

Comments

@bf
Copy link
Contributor

bf commented Mar 4, 2023

Is your suggestion for improvement related to a problem? Please describe.
Often times you find the PDF version of a file at a different website than the BIBTex citation. I'd like to have an more easy way to attach the PDF file via URL to a certain entry in my reference library without having to download it first. JabRef should handle download and storing PDF in right location, not me.

Describe the solution you'd like
Currently when you right-click on an entry the context menu appears. The context menu has an "Attach File..." button which allows you to use the file chooser to attach a PDF file. However, when doing this, the file is not copied into your "referenced files" folder and if you have the PDF file open in a browser tab you'd need to download it and then select the downloaded file.

Additional context
I'm away this functionality "Attach File From Url" is already implemented. But the user experience to get to it is quite cumbersome. First the entry needs to be created for the article, then you need to select it in Jabref, navigate the detail menu to register "General", then go to the "File" list and then on the right of the file list there is a tiny button labeled "Download from URL".

My - and I think many other's - workflow would be much easier if we can just navigate to a page in our browser tab (e.g. the official journal website), use JabRef browser extension to import the bibtex reference into JabRef, then copy the PDF URL from another browser tab (e.g. the researcher's github page where PDF is freely available) and then paste the URL via right-click context menu "Attach File from URL..." to the new entry.

If you agree I'm happy to provide a PR.

@Siedlerchr
Copy link
Member

Thanks for your suggestion, I fully agree with you. That would definitely be a usability and workflow improvement.
Feel free to create a PR!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2023

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@bf
Copy link
Contributor Author

bf commented Mar 4, 2023

My java was a bit rusty and the setting up of Eclipse raised several WTFs but in the end it worked.
The PR is at #9648

Let's move discussion over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants