Dark theme: Event log. Output not readable

[koppor]

1. Open Help -> "View event log"
   
2. See that the text is black (and not white)
   

This should be fixed.

[dlyrsk]

Hello, can I be assigned this issue?

[github-actions]

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

[dlyrsk]

I want to confirm if I understand it correctly:

jabref/src/main/java/org/jabref/gui/errorconsole/ErrorConsoleView.java

Lines 97 to 112 in 5e5b72b

	@Override
	public void updateItem(LogEventViewModel event, boolean empty) {
	super.updateItem(event, empty);
	if ((event == null) || empty) {
	setGraphic(null);
	} else {
	icon = event.getIcon().getGraphicNode();
	heading.setText(event.getDisplayText());
	heading.getStyleClass().setAll(event.getStyleClass());
	stacktrace.setText(event.getStackTrace().orElse(""));
	graphic.getStyleClass().setAll(event.getStyleClass());
	graphic.getChildren().setAll(icon, message);
	setGraphic(graphic);
	}
	}

In ErrorConsoleView, the ListCell was set with the following style classes depending on log level:

jabref/src/main/java/org/jabref/gui/errorconsole/LogEventViewModel.java

Lines 25 to 35 in 1c7da01

	public String getStyleClass() {
	switch (logEvent.getLevel()) {
	case ERROR:
	return "exception";
	case WARN:
	return "output";
	case INFO:
	default:
	return "log";
	}
	}

So, adding -fx-text-fill: -fx-text-background-color to these style classes could fix this bug. Is that correct?

[koppor]

I don't know about the styling in JabRef. We have a documentation of it there: https://docs.jabref.org/advanced/custom-themes#selection-of-useful-css-selectors. Feel free to add information about concrete styles.

If I was the one to work on the issue, I would check how the other text colors were done. (This context information is missing in your question).

[dlyrsk]

Yes I got that from other simlar ListView component. For example, org.jabref.gui.preferences.PreferencesDialogView#preferenceTabList and org.jabref.gui.texparser.ParseLatexResultView#referenceListVIew. They all have -fx-text-fill: -fx-text-base-color(I checked it again, it's not background-color), for example:

jabref/src/main/java/org/jabref/gui/texparser/ParseLatexResult.css

Lines 5 to 9 in 5e5b72b

	#referenceListView > .virtual-flow > .clipped-container > .sheet > .list-cell {
	-fx-padding: 4 4 4 4;
	-fx-background: transparent;
	-fx-text-fill: -fx-text-base-color;
	}

[dlyrsk]

Probably found one problem in the current error log console. The icon before warning log texts is smaller than others. It seems this isn't expected behavior, is it?

[koppor]

Not expected, looking forward to a fix!