Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular module dependency #193

Open
Dkhusainov opened this issue Jun 10, 2020 · 0 comments
Open

Circular module dependency #193

Dkhusainov opened this issue Jun 10, 2020 · 0 comments

Comments

@Dkhusainov
Copy link

dagger-compiler: 2.27
dagger-reflect: 0.2.0

dagger-compiler allows circular module dependencies(which is wrong, should be an error), while dagger-reflect hangs forever while trying to build Component with such modules.

Reproduce:

package test

@dagger.Component(modules = [Module1::class])
interface Component

@dagger.Module(includes = [Module2::class])
abstract class Module1

@dagger.Module(includes = [Module1::class])
abstract class Module2

class Test {
  @org.junit.Test
  fun test() {
    //dagger-compiler is silent on circular dependencies
//    DaggerComponent.create()

    //dagger-reflect hangs on infinite loop
    dagger.Dagger.create(test.Component::class.java)
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant