Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline comments #42

Open
sdobbs opened this issue Oct 8, 2016 · 2 comments
Open

Offline comments #42

sdobbs opened this issue Oct 8, 2016 · 2 comments

Comments

@sdobbs
Copy link
Collaborator

sdobbs commented Oct 8, 2016

We need another field where post-run comments could be added. It would be very useful if this could be be implemented before the next run.

@DraTeots
Copy link
Collaborator

DraTeots commented Oct 8, 2016

lets do it then. How to call that?

But the main thing here is to make these comments:

  1. Available from web site
  2. Should it be integrated to Sergey DAQ system? I.e. who and how should enter the comments?

@sdobbs
Copy link
Collaborator Author

sdobbs commented Oct 10, 2016

Okay, maybe we can call it "offline_comments"? I don't think that these comments need to be integrated to the DAQ system, they are explicitly post-DAQ and optional. The issue of who should be allowed to enter the comments is a good one, but there's no access controls on the rest of the DB so I think no restrictions are fine for now.

Ideally one would be able to view and edit these comments from the web site. Editing should involve some extra authentication work, and either one would have to access a copy of the website from inside the counting house or figure out a way to pass the values in from the outside. So, I think that to start with just modifying the comments via the python API is fine, but some more work would be needed to make this a non-expert activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants