Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] check results are coherent vs sklearn when using sample weights #41

Open
tlienart opened this issue Nov 11, 2019 · 0 comments

Comments

@tlienart
Copy link
Collaborator

tlienart commented Nov 11, 2019

We've recently added (JuliaAI/MLJModels.jl#125) the possibility to add weights to samples in KNNC, KNNR. It seems fine but it would still be good to check this a bit more and ideally against an external benchmark like Sklearn which I believe supports sample weights as well.

Steps:

  • be on the dev branch of MLJModels edit This now lives at NearestNeighborModels (current repo)
  • generate some dummy data with dummy weights (see also examples in tests for NearestNeighbors though it'd be better to use less dumb data where classes overlap a bit)
  • save the data and do the same analysis in sklearn
  • check that the results look roughly similar (like accuracy within +- 5%)
@ablaom ablaom transferred this issue from JuliaAI/MLJModels.jl Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant