Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter on PersistentHashMap inconsistent with Base #28

Open
TotalVerb opened this issue Aug 8, 2016 · 0 comments
Open

filter on PersistentHashMap inconsistent with Base #28

TotalVerb opened this issue Aug 8, 2016 · 0 comments

Comments

@TotalVerb
Copy link
Contributor

The Base version of filter on Dict requires a function that takes two arguments. That's not the case for PersistentHashMap. Arguably, the existing FunctionalCollections behaviour makes more sense; I've filed JuliaLang/julia#17886 over in Base. If Base transitions to one-argument, then nothing needs to be done; otherwise, I feel like PersistentHashMap must be changed too to avoid the surprise factor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant