Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement setindex! for geospatial data #282

Open
juliohm opened this issue Jul 28, 2023 · 2 comments
Open

Implement setindex! for geospatial data #282

juliohm opened this issue Jul 28, 2023 · 2 comments
Labels
enhancement good first issue help wanted

Comments

@juliohm
Copy link
Member

juliohm commented Jul 28, 2023

Currently our geospatial data types implement getindex to access the underlying table of attributes and geometries. We need the same high-level interface with setindex! to save users from having to learn and use Tables.jl explicitly.
@juliohm juliohm mentioned this issue Jan 22, 2024
Closed
@davibarreira
Copy link

The getindex seems to be implemented at GeoTables.jl. Is the setindex! also to be implemented there?

@juliohm
Copy link
Member Author

juliohm commented Sep 17, 2024

That was the original idea, but we need to wait on Tables.jl as it currently doesn't provide a setindex API.

We also concluded that the geometry column needs to be immutable for type stability in downstream algorithms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juliohm @davibarreira