Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many Exception subtypes don't accept an error message #14600

Closed
ssfrr opened this issue Jan 8, 2016 · 3 comments
Closed

Many Exception subtypes don't accept an error message #14600

ssfrr opened this issue Jan 8, 2016 · 3 comments
Labels
domain:error handling Handling of exceptions by Julia or the user

Comments

@ssfrr
Copy link
Contributor

ssfrr commented Jan 8, 2016

Some error types, like ErrorException and ArgumentError accept a string argument, but others (e.g. the ones defined in boot.jl do not.

Would a PR be accepted that added optional message fields to these error types? I came across this when throwing an InexactError and wanting to describe why the given value didn't fit into my type.
@KristofferC
Copy link
Sponsor Member

AFAIK the problem is performance when GC frames are created for the strings. Pretty sure there are discussions about it in some issue but can't find it

@KristofferC
Copy link
Sponsor Member

#12152 and #9693

@tkelman tkelman added the domain:error handling Handling of exceptions by Julia or the user label Jan 8, 2016
@timholy
Copy link
Sponsor Member

timholy commented Jul 11, 2017

Fixed by #20005

@timholy timholy closed this as completed Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:error handling Handling of exceptions by Julia or the user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ssfrr @KristofferC @timholy @tkelman