Should FileLogger close the io stream somehow?

[ericphanson]

LoggingExtras.jl/src/Sinks/filelogger.jl

Lines 19 to 20 in d35e7c8

	filehandle = open(path, append ? "a" : "w")
	FileLogger(filehandle; kwargs...)

Perhaps atexit(() -> close(io)) would be appropriate?

I have not seen any bugs from the current implementation, but I do worry one could lose logs when always_flush=false.

[fredrikekre]

I believe open files are closed when Julia exits (at least if it doesn't crash, but then I don't think atexit hooks would run either).

[ericphanson]

Ah I guess that's https://github.com/JuliaLang/julia/blob/5dfaef7a67c9b58ed272ba8557bcad103bb814e3/base/iostream.jl#L28 or similar?

Probably another reason JuliaLang/julia#51466 is dangerous then. But I guess it is safe for now, as long as we keep running finalizers on exit

[oxinabox]

the fear of losing logs due to a hard-crash when always_flush is false, is exactly why we provide the always_flush flag.