Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to adjust parametricbootstrap display for GLMMs w/o scale parameter #741

Closed
dmbates opened this issue Feb 3, 2024 · 3 comments · Fixed by #756
Closed

Need to adjust parametricbootstrap display for GLMMs w/o scale parameter #741

dmbates opened this issue Feb 3, 2024 · 3 comments · Fixed by #756

Comments

@dmbates
Copy link
Collaborator

dmbates commented Feb 3, 2024

A Bernoulli/binomial/Poisson GLMM does not have a scale parameter and parametricbootstrap produces a result in which the σ values are a vector of missing. The display or storage should be modified to take this into account.

Reproduce with

using MixedModels, TypedTables
contra = MixedModels.dataset(:contra)
contra = Table(contra, ch = contra.livch .≠ "0")
gm1 = let f = @formula use ~ 1 + age * ch + age^2 + urban + (1| dist & urban)
         fit(MixedModel, f, contra, Bernoulli(); nAGQ = 9)
       end
gm1samp = parametricbootstrap(2_000, gm1);
julia> typeof(gm1.σ)
Missing

julia> typeof(gm1samp.σ)
Vector{Missing} (alias for Array{Missing, 1})

Pretty much anything you try to do with gm1samp will throw an error.

@palday
Copy link
Member

palday commented Feb 3, 2024

It might be technically breaking to not store the sigma parameter, but we can definitely improve display and handling of it.

@dmbates
Copy link
Collaborator Author

dmbates commented Feb 3, 2024

Agreed. Do you want me to look at it or are you willing to do so? Assign it to me if you don't have time.

@palday
Copy link
Member

palday commented Feb 3, 2024

If it can wait a few days, I can do it. If you have big plans for it this week, then you should do it. 😄

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants