Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should real-world models have realistic sizes, assuming meter units #64

Open
jkieboom opened this issue Apr 27, 2021 · 7 comments
Open

Comments

@jkieboom
Copy link

The glTF spec says that linear distances have meter units. It looks like some models (for example BoomBox) do not use meter units. It looks like it's off by maybe a factor 10.

@elalish
Copy link
Contributor

elalish commented Apr 27, 2021

A boom box for ants! Yes, this has been annoying me for awhile. Would be amazing if someone could do a pass over all the real-world-ish objects and make sure they have appropriate scale. I recall that damaged helmet is oddly huge as well.

@bghgary
Copy link

bghgary commented Apr 27, 2021

Yes, at least for the boom box and probably other models contributed by Microsoft, our team should fix it. I know we updated the FlightHelmet to be correctly sized relatively recently. We should try to fix them at the source instead of hand editing the glTF models though.

@javagl
Copy link
Contributor

javagl commented Jan 11, 2023

Related/duplicate: #63

@DRx3D
Copy link
Contributor

DRx3D commented Nov 14, 2023

@bghgary : Has anything been done to address the original model sizes?

If no response to this comment, then the issue will be transferred to Sample Assets by 27 Nov.

@javagl
Copy link
Contributor

javagl commented Nov 14, 2023

This is a duplicate of #63 (with this one being more "generic", and the other one containing a bit more specifc (and relevant) infos, e.g. about the actual sizes of the models).

So it could be OK to move either of them, and close the other (I think that the mutual links remain intact even during a transfer, but in doubt, they can be added again after the transfer).

The other question is that from the last comment of the other issue at #63

Is there a Khronos process for getting these issues resolved? Everyone on this thread is in agreement about what should be done, but no one is clearly an owner. Should Khronos put out an RFP for someone to actually fix/upkeep the models in this repo?

Yeah 😬 well. We can revisit this after the transfer. Scaling some models should be trivial with glTF-Transform.

@bghgary
Copy link

bghgary commented Nov 15, 2023

If we don't have to fix the source asset, then it should be relatively straight forward to fix assuming we can figure out the proper physical size to target.

@bghgary
Copy link

bghgary commented Nov 15, 2023

Sorry, I didn't answer the question.

@bghgary : Has anything been done to address the original model sizes?

No, we have not done anything to address the model sizes.

@DRx3D DRx3D transferred this issue from KhronosGroup/glTF-Sample-Models Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants