-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should real-world models have realistic sizes, assuming meter units #64
Comments
A boom box for ants! Yes, this has been annoying me for awhile. Would be amazing if someone could do a pass over all the real-world-ish objects and make sure they have appropriate scale. I recall that damaged helmet is oddly huge as well. |
Yes, at least for the boom box and probably other models contributed by Microsoft, our team should fix it. I know we updated the FlightHelmet to be correctly sized relatively recently. We should try to fix them at the source instead of hand editing the glTF models though. |
Related/duplicate: #63 |
@bghgary : Has anything been done to address the original model sizes? If no response to this comment, then the issue will be transferred to Sample Assets by 27 Nov. |
This is a duplicate of #63 (with this one being more "generic", and the other one containing a bit more specifc (and relevant) infos, e.g. about the actual sizes of the models). So it could be OK to move either of them, and close the other (I think that the mutual links remain intact even during a transfer, but in doubt, they can be added again after the transfer). The other question is that from the last comment of the other issue at #63
Yeah 😬 well. We can revisit this after the transfer. Scaling some models should be trivial with glTF-Transform. |
If we don't have to fix the source asset, then it should be relatively straight forward to fix assuming we can figure out the proper physical size to target. |
Sorry, I didn't answer the question.
No, we have not done anything to address the model sizes. |
The glTF spec says that linear distances have meter units. It looks like some models (for example BoomBox) do not use meter units. It looks like it's off by maybe a factor 10.
The text was updated successfully, but these errors were encountered: