Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop requiring JDK 6 to run tests #2224

Closed
LouisCAD opened this issue Sep 2, 2020 · 2 comments
Closed

Stop requiring JDK 6 to run tests #2224

LouisCAD opened this issue Sep 2, 2020 · 2 comments

Comments

@LouisCAD
Copy link
Contributor

LouisCAD commented Sep 2, 2020

Hello, I'm working on #2213 and I get this on a machine that runs macOS Catalina (10.15.6), where it's not possible to install JDK 6 as far as I know:

> Task :kotlinx-coroutines-core:cleanJvmTest UP-TO-DATE
> Task :kotlinx-coroutines-core:checkJdk16 FAILED
FAILURE: Build failed with an exception.
* Where:
Build file '/Users/louiscad/Documents/GitHub/LouisCAD/kotlinx.coroutines/kotlinx-coroutines-core/build.gradle' line: 81
* What went wrong:
Execution failed for task ':kotlinx-coroutines-core:checkJdk16'.
> JDK_16 environment variable is not defined. Can't build against JDK 1.6 runtime and run JDK 1.6 compatibility tests. Please ensure JDK 1.6 is installed and that JDK_16 points to it.

Can you please drop this requirement? I think JDK 7 can do. Even better would be to have instructions depending on our OS in the error message to get setup without having to search on Google and focus back on whatever we were doing.

@elizarov
Copy link
Contributor

elizarov commented Oct 9, 2020

We don't require it anymore. Contribution docs were updated to more explicitly state it.

@elizarov elizarov closed this as completed Oct 9, 2020
@LouisCAD
Copy link
Contributor Author

LouisCAD commented Oct 9, 2020

Yep, I noticed, thank you for your action!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants