diff --git a/core/commonMain/src/kotlinx/serialization/modules/PolymorphicModuleBuilder.kt b/core/commonMain/src/kotlinx/serialization/modules/PolymorphicModuleBuilder.kt index 5a83e9233d..a6a7ada907 100644 --- a/core/commonMain/src/kotlinx/serialization/modules/PolymorphicModuleBuilder.kt +++ b/core/commonMain/src/kotlinx/serialization/modules/PolymorphicModuleBuilder.kt @@ -19,15 +19,23 @@ public class PolymorphicModuleBuilder @PublishedApi internal cons private val baseClass: KClass, private val baseSerializer: KSerializer? = null ) { - private val subclasses: MutableList, KSerializer>> = mutableListOf() + private val subclasses: MutableMap, KSerializer> = mutableMapOf() private var defaultSerializerProvider: ((Base) -> SerializationStrategy?)? = null private var defaultDeserializerProvider: ((String?) -> DeserializationStrategy?)? = null + + /** + * Registers the child serializers for the sealed [subclass] [serializer] in the resulting module under the [base class][Base]. + */ + public inline fun subclassesOf(): Unit = + subclassesOf(serializer()) + + /** - * Registers the subclasses of the given class as subclasses of the outer class. Currently this requires `baseClass` + * Registers the subclasses of the given class as subclasses of the outer class. This currently requires `baseClass` * to be sealed. */ - public fun subclassesOf(baseClass: KClass, serializer: KSerializer) { + public fun subclassesOf(serializer: KSerializer) { require(serializer is SealedClassSerializer) { "subClassesOf only supports automatic adding of subclasses of sealed types." } @@ -42,7 +50,7 @@ public class PolymorphicModuleBuilder @PublishedApi internal cons * Registers a [subclass] [serializer] in the resulting module under the [base class][Base]. */ public fun subclass(subclass: KClass, serializer: KSerializer) { - subclasses.add(subclass to serializer) + subclasses[subclass] = serializer } /** @@ -132,14 +140,8 @@ public inline fun PolymorphicModuleBuilder. public inline fun PolymorphicModuleBuilder.subclass(clazz: KClass): Unit = subclass(clazz, serializer()) -/** - * Registers the child serializers for the sealed [subclass] [serializer] in the resulting module under the [base class][Base]. - */ -public inline fun PolymorphicModuleBuilder.subclassesOf(serializer: KSerializer): Unit = - subclassesOf(T::class, serializer) - /** * Registers the child serializers for the sealed class [T] in the resulting module under the [base class][Base]. */ public inline fun PolymorphicModuleBuilder.subclassesOf(clazz: KClass): Unit = - subclassesOf(clazz, serializer()) + subclassesOf(clazz.serializer()) diff --git a/formats/json-tests/commonTest/src/kotlinx/serialization/features/PolymorphicSealedChildTest.kt b/formats/json-tests/commonTest/src/kotlinx/serialization/features/PolymorphicSealedChildTest.kt index 1957026c2c..47a3788dca 100644 --- a/formats/json-tests/commonTest/src/kotlinx/serialization/features/PolymorphicSealedChildTest.kt +++ b/formats/json-tests/commonTest/src/kotlinx/serialization/features/PolymorphicSealedChildTest.kt @@ -34,7 +34,7 @@ class PolymorphicSealedChildTest { val sealedModule = SerializersModule { polymorphic(FooBase::class) { - subclassesOf(Foo.serializer()) + subclassesOf() } }