Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a name/key to TranslationArgument #1037

Closed
kezz opened this issue Feb 22, 2024 · 2 comments
Closed

Add a name/key to TranslationArgument #1037

kezz opened this issue Feb 22, 2024 · 2 comments

Comments

@kezz
Copy link
Member

kezz commented Feb 22, 2024

Whilst unused in vanilla, it would be a pretty handy feature to have. For example, #972 could have named arguments based on the names of a TranslationArgument.

@zml2008
Copy link
Member

zml2008 commented Feb 24, 2024

I'm not super sure how I feel about this, since it'd go ahead of what the vanilla format can represent at this point in time -- virtual components are imo still the way forward for richer translations.

@kezz
Copy link
Member Author

kezz commented Feb 27, 2024

virtual components are imo still the way forward

I was actually playing about with virtual components on top of #972 and yeah, it does what we'd need for this anyway!

@kezz kezz closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants