Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest change visit_id int64 validation to str for AdmittedCareEpisodeSchema #28

Closed
georgm8 opened this issue Feb 9, 2023 · 3 comments

Comments

@georgm8
Copy link
Contributor

georgm8 commented Feb 9, 2023

We are currently hashing our visit_id (as well as patient_id) rendering this into a string and therefore failing the validation check as an integer is expected.

Would it be possible to change the schema accordingly to allow or this column to be hashed?

@vvcb
Copy link
Member

vvcb commented Feb 9, 2023

Visit_id is a unique row identifier which can be set to the dataframe index (int) and does not need hashing.

visit_id = df.reset_index(drop=True).index

@georgm8
Copy link
Contributor Author

georgm8 commented Feb 9, 2023

Agree this would be ok if the visit_id isn't required to link to any other datasets. Is the visit_id intended to link the Emergency Care to the Admitted Care table?

@vvcb
Copy link
Member

vvcb commented Feb 9, 2023

That is a good point. But, to my knowledge these have been requested as separate unlinked datasets and the analysis plan does not appear to suggest linked analysis.

Please use the workaround as above for now and I will incorporate this change in the next release.

Will be good to future proof this.

@vvcb vvcb closed this as completed in fa62ffe Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants