Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making edwaittime a nullable field #32

Closed
quindavies opened this issue Feb 14, 2023 · 2 comments
Closed

Making edwaittime a nullable field #32

quindavies opened this issue Feb 14, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@quindavies
Copy link
Collaborator

edwaittime currently fails validation as field not nullable - some records leave before being seen my clinician. This needs to be accounted for

@vvcb
Copy link
Member

vvcb commented Feb 14, 2023

edwaittime and timeined are currently set to int data type which causes problems with nan values even though they are set to be nullable.

Is there another column that allows us to identify these patients who left before being seen?

I will talk you through submitting your first pull request tomorrow! Can you please do a little bit of reading around this?

@vvcb vvcb added the bug Something isn't working label Feb 14, 2023
@georgm8
Copy link
Contributor

georgm8 commented Mar 1, 2023

Quite a few of the columns in the EmergencyCareEpisodeSchema are both enforced to be of type np.int64 and also specify nullable=True. Because nan values are floats these validation rules are fighting each other in the case nan values exist in the data.

Pandas does now support a Nullable integer data type

What do you think about applying the dtype=pd.Int64Dtype() to the schema? With the caveat that the Nullable integer data type is still 'experimental'

@vvcb vvcb closed this as completed in 311340b Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants