Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit protocols that are allowed in links #699

Closed
Nutomic opened this issue May 5, 2020 · 4 comments
Closed

Limit protocols that are allowed in links #699

Nutomic opened this issue May 5, 2020 · 4 comments
Labels
enhancement New feature or request type: discussion General talk without any clear action

Comments

@Nutomic
Copy link
Member

Nutomic commented May 5, 2020

For example, I can post the following link which opens the Steam settings if Steam is installed. I am sure there are some protocols that can do much worse. Firefox shows a confirmation dialog before doing anything, but we shouldnt rely on this.

steam://browsemedia

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@NicolasCARPi
Copy link

So what would be the whitelist?

  • https
  • http (<- actually not allowing http link would be an interesting take, be the web is not there yet, or maybe it could be blocked by default and admin could allow it if they wish, or the other way around)
  • (s)ftp
  • gopher
  • magnet ?

@ptman
Copy link
Contributor

ptman commented Jun 2, 2020

https://en.wikipedia.org/wiki/List_of_URI_schemes

@Nutomic Nutomic added type: discussion General talk without any clear action enhancement New feature or request labels Jun 2, 2020
@MayeulC
Copy link

MayeulC commented Jun 14, 2020

Perhaps this is what you are looking for? I'd suggest going with the "permanently" registered schemes first :)

Notably, a few that haven't been listed here: mumble, geo, h323, hyper.

@Nutomic
Copy link
Member Author

Nutomic commented Jun 14, 2020

Basically the idea is not to allow protocols that are insecure in some way (or could have an unintended effect when opened). Or only allow "secure" protocols, whatever that means exactly.

@Nutomic Nutomic closed this as completed Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request type: discussion General talk without any clear action
Projects
None yet
Development

No branches or pull requests

4 participants