Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heavy TPS Issues #34

Closed
TheButterbrotMan opened this issue Jun 6, 2022 · 7 comments
Closed

Heavy TPS Issues #34

TheButterbrotMan opened this issue Jun 6, 2022 · 7 comments
Assignees
Labels

Comments

@TheButterbrotMan
Copy link

Im experiencing heavy tps issues while using llamarama in my modpack. I think its caused by the Wandering Lama Traders. But im not sure.

@0xJoeMama
Copy link
Member

I suggest using a performance analysis mod like carpet to see what is affecting your TPS. A claim like "I think...But im not sure" will not get us anywhere, especially considering the size of the modpack(assuming it's deathdusk you are talking about).

@0xJoeMama 0xJoeMama self-assigned this Jun 7, 2022
@TheButterbrotMan
Copy link
Author

I did use spark for this. Spark clearly states your mod is eating TPS on my server. After I removed it I had thousands of entity llamarama: trader missing in my log.

@0xJoeMama
Copy link
Member

Could you provide the spark report for this?

@0xJoeMama
Copy link
Member

I am still awaiting the spark report. From the profiling I have done on my part our mobs aren't that big a lag causer. I will attempt to profile an instance again today but I feel without the spark report or the aforementioned log I won't be able to be of much help.

@0xJoeMama 0xJoeMama added help wanted Extra attention is needed question Further information is requested needs-more-info labels Jun 11, 2022
@0xJoeMama
Copy link
Member

Maybe the number of entities is causing an issue. I actually have debated about making Caravan traders despawn if none of their trades have ever been used. That would remove all traders except the ones players have actually found. I will consider that as a solution, however I still wish to see the log and the spark report. Furthermore the following link shows the result of placing 10 creepers and 10 caravan traders in a world. As you can see the caravan trader tick method, takes so little time that my profiler can't even detect the stack entering the method: https://streamable.com/zgzg0r

@TheButterbrotMan
Copy link
Author

Sadly I don't have this spark log anymore.

@TheButterbrotMan
Copy link
Author

Maybe the number of entities is causing an issue. I actually have debated about making Caravan traders despawn if none of their trades have ever been used. That would remove all traders except the ones players have actually found. I will consider that as a solution, however I still wish to see the log and the spark report. Furthermore the following link shows the result of placing 10 creepers and 10 caravan traders in a world. As you can see the caravan trader tick method, takes so little time that my profiler can't even detect the stack entering the method: https://streamable.com/zgzg0r

But I think that's probably the reason. There was just a lot of them.

@0xJoeMama 0xJoeMama added enhancement New feature or request and removed help wanted Extra attention is needed question Further information is requested needs-more-info labels Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants