Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align VaultInternal with context API functions with NodeConnectionManager #356

Closed
tegefaulkes opened this issue Mar 9, 2022 · 4 comments · Fixed by #374
Closed

Align VaultInternal with context API functions with NodeConnectionManager #356

tegefaulkes opened this issue Mar 9, 2022 · 4 comments · Fixed by #374
Assignees
@CMCDragonkai
Labels
development Standard development r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management

Comments

@tegefaulkes
Copy link
Contributor

Specification

When performing operations with a vault, expect to pass a callback that receives the vault. I would want to align the API between NodeConnectionManager and VaultManager. This requires further specification.

Refer to #335

Additional context

Tasks

  1. ...
  2. ...
  3. ...
@tegefaulkes tegefaulkes added the development Standard development label Mar 9, 2022
@CMCDragonkai CMCDragonkai mentioned this issue May 9, 2022
Closed
33 tasks
@tegefaulkes tegefaulkes mentioned this issue May 20, 2022
Merged
40 tasks
@emmacasolin
Copy link
Contributor

The description of #374 says it fixed this issue - can this be closed now? @tegefaulkes

@tegefaulkes
Copy link
Contributor Author

I think so. If I recall the sub-issues from #374 didn't auto close. @CMCDragonkai manually closed them. I'm not sure if he missed this or had a reason to leave it open.

@CMCDragonkai
Copy link
Member

No I don't think this is done yet. But @tegefaulkes can verify it.

@teebirdy teebirdy added the r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management label Jul 24, 2022
@CMCDragonkai
Copy link
Member

I'm closing this since this has not been well specified.

@CMCDragonkai CMCDragonkai closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2023
@CMCDragonkai CMCDragonkai self-assigned this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CMCDragonkai CMCDragonkai

Labels
development Standard development r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management
Milestone
No milestone
4 participants
@CMCDragonkai @tegefaulkes @emmacasolin @teebirdy