Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Transaction::GetWriteBatch to get batch information about the transaction #36

Open
CMCDragonkai opened this issue Jun 26, 2022 · 0 comments
Labels
development Standard development r&d:polykey:supporting activity Supporting core activity

Comments

@CMCDragonkai
Copy link
Member

Specification

The usage of Transaction::GetWriteBatch returns a map structure called WriteBatchWithIndex which can be used to interrogate what is inside a transaction.

The map structure can show us what is about to be committed in to the transaction. This can be useful for debugging.

To integrate this, we should start using shared pointers in C++ to make our GC a little easier. I'm not sure how that would work with the napi_ref reference counting.

Additional context

Tasks

  1. ...
  2. ...
  3. ...
@CMCDragonkai CMCDragonkai added the development Standard development label Jun 26, 2022
@teebirdy teebirdy added r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management and removed r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management labels Jul 24, 2022
@CMCDragonkai CMCDragonkai self-assigned this Jul 10, 2023
@CMCDragonkai CMCDragonkai added the r&d:polykey:supporting activity Supporting core activity label Jul 10, 2023
@CMCDragonkai CMCDragonkai removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development r&d:polykey:supporting activity Supporting core activity
Development

No branches or pull requests

2 participants