Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up superfluous compilation flags #43

Open
CMCDragonkai opened this issue Jul 14, 2022 · 0 comments · May be fixed by #63
Open

Clean up superfluous compilation flags #43

CMCDragonkai opened this issue Jul 14, 2022 · 0 comments · May be fixed by #63
Labels
development Standard development r&d:polykey:supporting activity Supporting core activity

Comments

@CMCDragonkai
Copy link
Member

Specification

The current gyp files specify compilation flags in such a way that it leads to repeated superfluous flags.

But I did notice that the compilation settings are a bit messy, worth looking into cleaning it up so it's clearer. Messy settings include multiple overrides of -std and -stdlib, and -mmacosx-version-min and -arch. It's also not entirely consistent between the deps and this js-db's native binding.

Basically I believe flags/options like -std, -stdlib, and -mmacosx-version-min and -arch should be configured so there's not so much repetition.

This has to do with the way our binding.gyp is specifying the compilation options. The gyp format has a lot of ways of doing things, and it is likely some options are being "appended", where we should actually override existing options, rather than just appending new options.

At the same time, the node-gyp sort of combines the gyp files with configuration coming from the default gyp file that is in nodejs itself, and that can be a source of problems.

Additional context

Tasks

  1. ...
  2. ...
  3. ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development r&d:polykey:supporting activity Supporting core activity
Development

Successfully merging a pull request may close this issue.

1 participant