Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ExportAttribute to DllExportAttribute #7

Closed
batzen opened this issue Sep 28, 2019 · 2 comments
Closed

Rename ExportAttribute to DllExportAttribute #7

batzen opened this issue Sep 28, 2019 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@batzen
Copy link

batzen commented Sep 28, 2019

I guess the name "DllExport" more accurately expresses what is done, in comparison to "Export".

@MeikTranel
Copy link
Owner

The decision to name it Export instead of DllExport definitely was intentional, as i wanted to avoid the conflict with UnmanagedExports. I personally don't think reving to a next major version right now because of a very minor semantic flavor in type naming is warranted.
I do however get the reasoning: .NET calls its importing counterpart DllImport, thus the reverse makes sense.
Maybe we can do this in the timeframe of a 1.0 release. You can always do

  using DllExportAttribute = NXPorts.Attributes.ExportAttribute;

in the meantime.

@MeikTranel MeikTranel added this to the 1.0 milestone Sep 28, 2019
@MeikTranel MeikTranel added the enhancement New feature or request label Sep 28, 2019
@filmor
Copy link
Contributor

filmor commented Nov 6, 2019

You are at 0.1, I don't see any problem with changing the name now. No one is expecting API stability from a pre 1.0 library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants