Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTMLObjectElement has alt attribute only in Internet Explorer (and edge?) #21386

Closed
HolgerJeromin opened this issue Jan 24, 2018 · 2 comments
Closed

HTMLObjectElement has alt attribute only in Internet Explorer (and edge?) #21386

HolgerJeromin opened this issue Jan 24, 2018 · 2 comments
Assignees
@mhegazy
Labels
Breaking Change Would introduce errors in existing code Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Milestone
TypeScript 2.8

Comments

@HolgerJeromin
Copy link
Contributor

TypeScript Version: 2.6.3

lib.dom.d.ts has alt attribute for HTMLObjectElement:
https://github.com/Microsoft/TypeScript/blob/5b5a00745997768fad7d3a4c98931af179fa277a/lib/lib.dom.d.ts#L5981-L5986

This is not in HTML Standard, Firefox or Chrome available.
@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript API Relates to the public API for TypeScript and removed API Relates to the public API for TypeScript labels Jan 24, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Jan 24, 2018

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

@mhegazy mhegazy added the Help Wanted You can do this label Jan 24, 2018
@mhegazy mhegazy added this to the Community milestone Jan 24, 2018
@benbraou
Copy link
Contributor

@mhegazy I would like to work on this issue

benbraou added a commit to benbraou/TSJS-lib-generator that referenced this issue Jan 24, 2018
@benbraou
Remove alt attribute from HTMLObjectElement interface
3acbfee 
alt is not part of the HTML Standard for HTMLObjectElement

Fixes microsoft/TypeScript#21386
@benbraou benbraou mentioned this issue Jan 24, 2018
Merged
@mhegazy mhegazy added the Breaking Change Would introduce errors in existing code label Jan 24, 2018
benbraou added a commit to benbraou/TSJS-lib-generator that referenced this issue Jan 24, 2018
@benbraou
Remove alt attribute from HTMLObjectElement interface
4b9ffc4 
alt is not part of the HTML Standard for HTMLObjectElement

Fixes microsoft/TypeScript#21386
benbraou added a commit to benbraou/TSJS-lib-generator that referenced this issue Jan 24, 2018
@benbraou
Remove alt attribute from HTMLObjectElement interface
dd8fadd 
alt is not part of the HTML Standard for HTMLObjectElement

Fixes microsoft/TypeScript#21386
@mhegazy mhegazy modified the milestones: Community, TypeScript 2.8 Jan 29, 2018
@mhegazy mhegazy self-assigned this Jan 29, 2018
@mhegazy mhegazy added the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Jan 29, 2018
@mhegazy mhegazy reopened this Jan 29, 2018
@mhegazy mhegazy mentioned this issue Feb 12, 2018
Merged
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Feb 12, 2018
@mhegazy mhegazy removed the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Feb 12, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mhegazy mhegazy

Labels
Breaking Change Would introduce errors in existing code Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 2.8
Development

No branches or pull requests
4 participants
@HolgerJeromin @RyanCavanaugh @mhegazy @benbraou