Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

add path mapping #147

Merged
merged 1 commit into from
Jan 17, 2017
Merged

add path mapping #147

merged 1 commit into from
Jan 17, 2017

Conversation

llgcode
Copy link
Contributor

@llgcode llgcode commented Jan 5, 2017

Hi @roblourens
this pr fixes #146 and have to be merged with microsoft/vscode-chrome-debug#324
I added pathMapping in the launcher config:
So it replace webRoot and sourceMapPathOverrides that are no longer needed to configure a launcher
I've tested with some typescript and sourcemap and it seems to work fine with just a pathMapping.

It was tricky to configure the debug environment but I finally installed projects and found the right procedure for launching.

@msftclas
Copy link

msftclas commented Jan 5, 2017

Hi @llgcode, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftgits
Copy link
Contributor

msftgits commented Jan 5, 2017

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

@msftgits msftgits closed this Jan 5, 2017
@msftgits msftgits reopened this Jan 5, 2017
@msftclas
Copy link

msftclas commented Jan 5, 2017

Hi @llgcode, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@roblourens
Copy link
Member

This is great, thanks for the PR! I don't think I want to deprecate webRoot, since it's simple and almost always the only thing someone needs. But I'll merge and test and release this when I have a minute.

@llgcode llgcode mentioned this pull request Jan 11, 2017
@roblourens roblourens merged commit 9503839 into microsoft:master Jan 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map local folder to URL
4 participants