Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default logger output path should be cmd-line friendly #244

Closed
TheRealPiotrP opened this issue Nov 24, 2016 · 2 comments
Closed

Default logger output path should be cmd-line friendly #244

TheRealPiotrP opened this issue Nov 24, 2016 · 2 comments
Assignees
@Faizan2304
Labels
enhancement exp: cli
Milestone
Preview 110.3 - 2...

Comments

@TheRealPiotrP
Copy link
Contributor

The .trx file written for CLI tests gets written to a path like:

.../cli/test/dotnet-migrate.Tests/TestResults/_MacBook-Pro 2016-11-24 02:16:53.trx

The space between Pro and 2016 was a bit jarring on the cmd line. I tried executing more cli/test/dotnet-migrate.Tests/TestResults/_MacBook-Pro 2016-11-24 02:16:53.trx and this failed because I didn't quote the path and it contained a space.

This seems quite unnatural on OS X. I think that OS and its apps tend to avoid spaces in paths.
@codito
Copy link
Contributor

codito commented Nov 24, 2016

+1. This will be a behavior difference from previous versions of mstest or vstest.console, I don't think users will mind it though. @pvlakshm thoughts?

@codito
Copy link
Contributor

codito commented Nov 28, 2016

Triage:
Test platform should replace whitespace with underscore in the generated file name.

@codito codito added this to the Preview 110.3 - 20161209 milestone Dec 5, 2016
@Faizan2304 Faizan2304 mentioned this issue Dec 6, 2016
Merged
harshjain2 pushed a commit that referenced this issue Dec 10, 2016
@Faizan2304 @harshjain2
Replace whilespace with underscore in the name of trx file. (#261)
6f42bbc 
* Replace whilespace with underscore in the name of trx file.
Issue: #244

Validation:
1)Added unit test to cover changes.
2) Manually validated on linux and windows machine

* Address PR comment

* Renamed TestableTrxLogger.
@codito codito closed this as completed Dec 10, 2016
@codito codito mentioned this issue Dec 16, 2016
Merged
@AbhitejJohn AbhitejJohn mentioned this issue May 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Faizan2304 Faizan2304

Labels
enhancement exp: cli
Projects
None yet
Milestone
Preview 110.3 - 20161209
Development

No branches or pull requests
3 participants
@codito @TheRealPiotrP @Faizan2304