Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for coded UI test debug broken #1352

Merged
merged 3 commits into from
Jan 3, 2018

Conversation

smadala
Copy link
Contributor

@smadala smadala commented Dec 29, 2017

  • Porting to master.
  • TMIHelper from d15.6stg.
  • Keep the default VSIX version in Int32 range.

Related issue

Can't debug coded UI test in latest VS2017

@@ -22,7 +26,7 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Internal.TestPlatform.Extensions">
<Version>15.6.0-preview-1202328</Version>
<Version>$(TestPlatformExternalsVersion)</Version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@@ -433,16 +433,17 @@ function Create-VsixPackage
$testImpactComComponentsDir = Join-Path $extensionsPackageDir "TestImpact"
$legacyTestImpactComComponentsDir = Join-Path $extensionsPackageDir "V1\TestImpact"

$testPlatformExternalsVersion = "15.6.0-preview-1251113"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[xml](Get-Content $TP_ROOT_DIR\scripts\build\TestPlatform.Dependencies.props).Project.PropertyGroup.TestPlatformExternalsVersion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was searching for this 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@codito
Copy link
Contributor

codito commented Dec 29, 2017

I was about to declare #1351 as the last PR to vstest for 2017, and then this one... @smadala on a roll today ;) 👍

Copy link
Contributor

@mayankbansal018 mayankbansal018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to investigate that, rather than acquiring dependencies from nuget, & inserting it back, we create a vsix in devdiv, which directly drop these dependencies into Testplatform\Externals, just like we didf for UWP recently?

@smadala smadala self-assigned this Jan 2, 2018
@smadala
Copy link
Contributor Author

smadala commented Jan 2, 2018

@mayankbansal018 I had discussed same with @codito. We thought that will cause different versions of external assemblies(MSTestv1 adapter, etc) ships in Microsoft.Testplatform nuget package and VS.

@mayankbansal018
Copy link
Contributor

@smadala, I agree there could be different bits in VS preview, & TP nuget preview bits, but we can make sure that same version ends up in non-preview bits of Testplatform nugets, & in official VS release.

Which should be acceptable. It also avoids us making insertions in VS, just to update some dependencies, & we also need to go through the check-points, which we can avoid. I think it's worth it.

@codito
Copy link
Contributor

codito commented Jan 2, 2018

In my opinion, we shouldn't fragment the distribution with more packages. While we get to do less VS insertions, but the cost of validation (i TPv2 vsix with j external vsix) and risk of human errors will increase. For instance, right now the acceptance tests give good confidence, with i and j variable, how should we ensure quality? And how do we ensure that VSTS task == VS insertion for every commit?

I'd rather fix the issues with VS insertion process if there are any, or plan the insertions better.

@smadala smadala merged commit 9d85df9 into microsoft:master Jan 3, 2018
@smadala smadala deleted the codedui-debug-fix branch January 3, 2018 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants