FilterOptions is not serialized correctly when running .NET Core tests #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishkk
requested review from
smadala,
genlu,
acesiddhu,
cltshivash,
singhsarab and
mayankbansal018
smadala
approved these changes
Apr 19, 2018
| { | ||
| TestCaseFilter = this.actualTestRunCriteria.TestCaseFilter | ||
| }; | ||
| testRunCriteria = new TestRunCriteria(new[] { nextSource }, this.actualTestRunCriteria); |
There was a problem hiding this comment.
actualTestRunCriteria [](start = 85, length = 21)
how was parallel ever working?
There was a problem hiding this comment.
When FilterOptions are used, it never works. otherwise with test case filter it does.
genlu
approved these changes
Apr 19, 2018
singhsarab
changed the title
singhsarab
pushed a commit
to singhsarab/vstest
that referenced
this pull request
Apr 20, 2018
microsoft#1551) * Initial commit * Passing Filter Options to each execution manager of parallal execution. * Unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#1539
Fix:
ParallelProxyExecutionManager send execution request to each execution manager passing a copy of testRunCriteria with different sources.
While copying from TestRunCriteria, FilterOptions was not passed to each execution manager's testRunCriteria.
Fix contains changes to pass FilterOptions to each execution manager in case of Parallal run.