Legacysettings telemetry #1564
Merged
Legacysettings telemetry #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaadhina
approved these changes
Apr 26, 2018
smadala
approved these changes
Apr 26, 2018
| } | ||
| catch(Exception ex) | ||
| { | ||
| EqtTrace.Error("Error while trying to read legacy settings. Message:", ex.Message); |
There was a problem hiding this comment.
Add {0} and print ex.ToString().
| { | ||
| requestData.MetricsCollection.Add(TelemetryDataConstants.TestSettingsUsed, InferRunSettingsHelper.IsTestSettingsEnabled(runsettings)); | ||
|
|
||
| if (InferRunSettingsHelper.TryGetLegacySettings(runsettings, out List<string> legacySettings)) |
There was a problem hiding this comment.
Nit: Rename legacySettings to legacySettingsElements.
| Assert.IsFalse((bool)testSettingsUsed); | ||
|
|
||
| // Opt out the Telemetry | ||
| Environment.SetEnvironmentVariable("VSTEST_TELEMETRY_OPTEDIN", "0"); |
| @@ -17,6 +17,10 @@ public static class TelemetryDataConstants | |||
| // Total time taken to complete one test run request | |||
| public static string TimeTakenInSecForRun = "VS.TestRun.TimeTakenInSec"; | |||
|
|
|||
| public static string TestSettingsUsed = "VS.TestRun.TestSettingsUsed"; | |||
There was a problem hiding this comment.
Nit: Rename this to IsTestSettingsUsed.
|
Add link to user story. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the telemetry points for