Fix attachment uri in trx if same attachment filename is same #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigurr
reviewed
May 31, 2018
| @@ -148,6 +148,11 @@ public static TrxObjectModel.TestOutcome ToOutcome(ObjectModel.TestOutcome rockS | |||
|
|
|||
| public static List<CollectorDataEntry> ToCollectionEntries(IEnumerable<ObjectModel.AttachmentSet> attachmentSets, TestRun testRun, string trxFileDirectory) | |||
| { | |||
| if (EqtTrace.IsInfoEnabled) | |||
| { | |||
| EqtTrace.Info($"Converter.ToCollectionEntries: Converting attachmentSets {string.Join(",", attachmentSets)} to collection entries."); | |||
There was a problem hiding this comment.
attachmentSets null check is below and here we are printing before null check?
There was a problem hiding this comment.
Thanks. added null check.
nigurr
reviewed
May 31, 2018
|
|
||
| public override string ToString() | ||
| { | ||
| return $"{nameof(Uri)}: {Uri.AbsoluteUri}, {nameof(DisplayName)}: {DisplayName}, {nameof(Attachments)}: [{ string.Join(",", Attachments)}]"; |
There was a problem hiding this comment.
Not sure about that. However we are using AbsoluteUri in other places without any check. Not adding null check here.
nigurr
approved these changes
Jun 1, 2018
|
@dotnet-bot test this please. |
|
@dotnet-bot test this please |
|
@dotnet-bot test Ubuntu14.04 / Debug Build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1626