Show error message on Framework35 #1723
Conversation
| @@ -276,11 +276,14 @@ | |||
| <data name="FileNotFound" xml:space="preserve"> | |||
| <value>'{0}' not found.</value> | |||
| </data> | |||
| <data name="Framework35NotSupported" xml:space="preserve"> | |||
| <value>Framework35 not supported. Use Framework40 or above to run tests in CLR 4.0 "compatibly mode".</value> | |||
There was a problem hiding this comment.
Suggestion:
Framework35 is not supported. For projects targeting .Net Framework 3.5, please use Framework40 to run tests in CLR 4.0 "compatibility mode".
There was a problem hiding this comment.
Approving with suggestions.
@cltshivash @pvlakshm please review the change in behaviour
| string runSettingsXml = @"<?xml version=""1.0"" encoding=""utf-8""?> | ||
| <RunSettings> | ||
| <RunConfiguration> | ||
| <TargetFrameworkVersion>Framework35</TargetFrameworkVersion> |
There was a problem hiding this comment.
Add test with explicit version, .NetFramework,version=3.5
| @@ -75,7 +81,8 @@ public void HandleRawMessage(string rawMessage) | |||
|
|
|||
| public void HandleLogMessage(TestMessageLevel level, string message) | |||
| { | |||
| // No Op | |||
| this.TestMessageLevels.Add(level); | |||
There was a problem hiding this comment.
Instead use a List of keyValuePairs or define a struct
…a/vstest into add-warning-fx35-assembly
|
Are we erroring out if Framework35 is specified? We should not. Today, we run such tests in CLR 4.0's compat mode. Just call that out as a warning so the user is more aware. |
|
@pvlakshm In Tpv1 if user passes Framework35, tests runs in CLR 2.0 process. From VS 15.5 we have changed that behavior to run tests CLR 4.0 process in As we don't support running tests in CLR 2.0 process, we should remove the |
Error makes more awareness. More details refer #1643 (comment) |
This reverts commit 310968a.
Description
/Framework:Framework35as we don't have testhost built for CLR 2.0Related issue
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/493289