Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Avoid usage of JsonConvert in test host process #1881

Merged
merged 4 commits into from
Jan 3, 2019

Conversation

abhishkk
Copy link
Contributor

Related issue

#1757

@abhishkk
Copy link
Contributor Author

abhishkk commented Jan 3, 2019

@dotnet-bot test this please

@abhishkk abhishkk closed this Jan 3, 2019
@abhishkk abhishkk reopened this Jan 3, 2019
Copy link
Contributor

@cltshivash cltshivash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:


var classWithSelfReferencingLoop = new ClassWithSelfReferencingLoop(null);
classWithSelfReferencingLoop = new ClassWithSelfReferencingLoop(classWithSelfReferencingLoop);
classWithSelfReferencingLoop.InfiniteRefernce.InfiniteRefernce = classWithSelfReferencingLoop;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: InfiniteReference*

@abhishkk abhishkk merged commit 5689373 into microsoft:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants