Added tests for netcoreapp1.1 #270
Conversation
|
@dotnet-bot test this please |
|
Any reason to choose new test asset projects? We could multitarget existing test asset to |
|
@codito My initial thought was to keep separate folder, but it seems like we will end up having so many folders as netcoreapp evolve further. |
| @@ -2,8 +2,9 @@ | |||
| <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" /> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>net46</TargetFramework> | |||
| <TargetFrameworks>net46;netcoreapp1.1</TargetFrameworks> | |||
There was a problem hiding this comment.
We want to support netcoreapp1.0 as well.
| @@ -2,9 +2,9 @@ | |||
| <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" /> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>netcoreapp1.0;net46</TargetFrameworks> | |||
| <TargetFrameworks>netcoreapp1.0;net46;netcoreapp1.1</TargetFrameworks> | |||
There was a problem hiding this comment.
Do we need to modify the e2e test for running this test project targeting netcoreapp1.1?
| /// <summary> | ||
| /// The custom data test method attribute. | ||
| /// </summary> | ||
| public class CustomDataTestMethodAttribute : TestMethodAttribute |
| { | ||
| AcceptanceTestBase.SetTestEnvironment(this.testEnvironment, runnerFramework, targetFramework, targetRuntime); |
There was a problem hiding this comment.
Can this move to TestInitialize?
There was a problem hiding this comment.
The intention behind keeping it here is that the parameters for method will come from data rows.
| <PackageTargetFallback Condition=" '$(TargetFramework)' == 'netcoreapp1.0' ">$(PackageTargetFallback);dnxcore50;portable-net45+win8</PackageTargetFallback> | ||
| <OutputType Condition=" '$(TargetFramework)' == 'netcoreapp1.0' ">Exe</OutputType> | ||
| <PackageTargetFallback Condition=" '$(TargetFramework)' == 'netcoreapp1.0' Or '$(TargetFramework)' == 'netcoreapp1.1' ">$(PackageTargetFallback);dnxcore50;portable-net45+win8</PackageTargetFallback> | ||
| <OutputType Condition=" '$(TargetFramework)' == 'netcoreapp1.0' Or '$(TargetFramework)' == 'netcoreapp1.1' ">Exe</OutputType> |
There was a problem hiding this comment.
Better to invert this to compare with net46.
|
👍 |
Added tests for netcoreapp1.1.
#167