Allow VSTestConsole path to be specified #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also moves the tasks dll to netstandard.library to improve our ability to merge dependencies
codito
approved these changes
Jan 10, 2017
|
Do we have a build with this change? We'd love to use it as part of a PR we're working on. What is the package version? |
|
👀 |
|
@piotrpMSFT sorry for delay. You can get the latest package for Microsoft.TestPlatform.Build from https://dotnet.myget.org/F/vstest/auth/967ad631-d24c-4c0e-bece-922de3064956/api/v3/index.json feed. The package name should have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CLI we're separating MSBuildToolsPath from MSBuildExtensionsPath. VS Test Console task currently assumes the TestConsole.dll gets installed next to msbuild.exe [due to use of AppContext.BaseDirectory]. This change enables callers to pass the Console path to the task.
Also moves the tasks dll to netstandard.library to improve our ability to merge dependencies