Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Pass Uri and FrameId into Frame::NavigationCompleted and NavigationStarted event handler #4604

Open
pushkin- opened this issue May 31, 2024 · 1 comment
Labels
feature request feature request tracked We are tracking this work internally.

Comments

@pushkin-
Copy link

pushkin- commented May 31, 2024

Describe the feature/enhancement you need

I want to access the FrameId inside of the CoreWebView2::FrameNavigationCompleted or Frame::NavigationCompleted events as well as FrameNavigationStarting. See all the info here that Electron passes in a similar event.

NavStarting args have Uri but not FrameId

Also to DomContentLoaded - frameID would be useful here for me.

The scenario/use case where you would use this feature

Need to detect when a frame navigates and see what frame it was. Similar to this request (which is also helpful to me) where they suggest passing the Uri property in.

I'm currently having to intercept FrameCreated and then Frame::NavigationStarting and save off e.Uri in some map, keyed by e.NavigationId, and then pull it out in Frame::NavigationCompleted

How important is this request to you?

Nice to have. There are other ways to tackle this, but having official API support would be beneficial.

Suggested implementation

pass info that Electron passes in like uri, frameId. (they have two different frameIds, maybe both make sense to pas? not sure)

What does your app do? Is there a pending deadline for this request?

No response

AB#53262297

@pushkin- pushkin- added the feature request feature request label May 31, 2024
@pushkin- pushkin- changed the title [Feature]: [Feature]: Pass Uri and FrameId into Frame::NavigationCompleted event handler May 31, 2024
@userbabu
Copy link

Yes, it's very useful, but unfortunately he didn't

@pushkin- pushkin- changed the title [Feature]: Pass Uri and FrameId into Frame::NavigationCompleted event handler [Feature]: Pass Uri and FrameId into Frame::NavigationCompleted and NavigationStarted event handler Jul 18, 2024
@victorhuangwq victorhuangwq added the tracked We are tracking this work internally. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request feature request tracked We are tracking this work internally.
Projects
None yet
Development

No branches or pull requests

3 participants