Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any no-op implementation already? #15

Open
mochadwi opened this issue Apr 16, 2020 · 4 comments
Open

Is there any no-op implementation already? #15

mochadwi opened this issue Apr 16, 2020 · 4 comments

Comments

@mochadwi
Copy link

Does this library wouldn't be crashed if we only define the debugImplementation? The initialization class will be red in releaseImplementation

@mochadwi
Copy link
Author

@vijai1996
Copy link

I have been making quite some changes to a fork of this library here as a part of it, thanks to your issue, I implemented no-op.

Please note, the readme is still to be updated and maybe a wiki in future. But, you can use

'com.orpheusdroid.crashreporter:crashreporter:1.0.3' for full implementation and
'com.orpheusdroid.crashreporter:crashreporter-no-op:1.0.3' for the no-op implementation.

Further, while using no-op make sure you wrap CrashReporterActivity with BuildConfig.debug condition if you are using it. Since the no-op version's CrashReporterActivity is an empty class while the actual one is an activity.

Refer to this example if still not clear.

@mochadwi
Copy link
Author

will leave this issue open for future reader

@mochadwi
Copy link
Author

I have been making quite some changes to a fork of this library here as a part of it, thanks to your issue, I implemented no-op.

Please note, the readme is still to be updated and maybe a wiki in future. But, you can use

'com.orpheusdroid.crashreporter:crashreporter:1.0.3' for full implementation and
'com.orpheusdroid.crashreporter:crashreporter-no-op:1.0.3' for the no-op implementation.

Further, while using no-op make sure you wrap CrashReporterActivity with BuildConfig.debug condition if you are using it. Since the no-op version's CrashReporterActivity is an empty class while the actual one is an activity.

Refer to this example if still not clear.

thank you so much @vijai1996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants