Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove regex for ghp_ token #95

Closed
vandlol opened this issue Aug 4, 2021 · 2 comments
Closed

Please remove regex for ghp_ token #95

vandlol opened this issue Aug 4, 2021 · 2 comments

Comments

@vandlol
Copy link

vandlol commented Aug 4, 2021

This change just broke the playbook for me.
My perfectly alright token is no longer working.
Also, if you need to check for a token prefix (which seems odd to me) please check for all of the prefixes:
ghp for GitHub personal access tokens
gho for OAuth access tokens
ghu for GitHub user-to-server tokens
ghs for GitHub server-to-server tokens
ghr for refresh tokens
I am using your Playbook on a Github Enterprise Server which does not need any prefixes for tokens.
Please make this optional or something.

Cheers

@MonolithProjects
Copy link
Owner

Hmm you are right about the token on Github Enterprise Server. I was not thinking about it when i was merging #93 Gonna fix it...

@MonolithProjects
Copy link
Owner

done #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants