Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component.json support for bower #190

Closed
andriijas opened this issue Dec 7, 2012 · 6 comments
Closed

Add component.json support for bower #190

andriijas opened this issue Dec 7, 2012 · 6 comments

Comments

@andriijas
Copy link

Please consider adding a component.json file so that tablesorter can be installed via bower

https://github.com/twitter/bower

@Mottie
Copy link
Owner

Mottie commented Dec 18, 2012

Thanks for sharing!

I forgot to work on this for version 2.6, but I'll try to include it in the next update.

@Mottie
Copy link
Owner

Mottie commented Dec 19, 2012

Hmm, ok after reading the requirements:

There should only be at most one file per file type in the main list. So only one .js or .css.

I'd have to add an "all" js file with the core, pager and widgets combined. I could probably get away with just including one css theme file since the default and a few others don't require any extra image files.

Maybe I should just wait until we get the make file system set up in version 3? Or do you think just providing only the core/widget files with one theme good enough?

@andriijas
Copy link
Author

Hmm let's wait I'd say its nit exactly a deal breaker :)

@vendethiel
Copy link

There's no need for the main property, bower clones the repo to let you use whichever files you need.

@Mottie
Copy link
Owner

Mottie commented Jan 18, 2013

Thanks @Nami-Doc!

I'll reopen this issue and add a component.json soon!

@Mottie Mottie reopened this Jan 18, 2013
@Mottie
Copy link
Owner

Mottie commented Jan 24, 2013

Added thanks to @appleboy in #222

@Mottie Mottie closed this as completed Jan 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants