Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anatGetAll documentation should specify defs=NULL works and what it does #259

Closed
gdevenyi opened this issue May 23, 2019 · 4 comments
Closed

Comments

@gdevenyi
Copy link
Contributor

If I don't have a defs file, anatGetAll should just use the label number from the atlas file.

@cfhammill
Copy link
Member

It does (or should). Does this not work anymore?

https://github.com/Mouse-Imaging-Centre/RMINC/blob/master/R/minc_anatomy.R#L256

@gdevenyi gdevenyi changed the title anatGetAll should allow no defs specified anatGetAll documentation should specify defs=NULL works and what it does May 23, 2019
@gdevenyi
Copy link
Contributor Author

Ah. So it does.

But it defaults to a environment variable and bails out on error if unspecified.

Also, the docs don't say NULL is allowed. :)

@cfhammill
Copy link
Member

Oops, my fault, Sys.getenv on fail returns an empty string instead of NULL, so on other systems the default gets initialized incorrectly. I'll fix and doc, thanks for the spot.

@cfhammill
Copy link
Member

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants