New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch PNI product voting CSRF over to just-in-time fetching #7880

Closed

Pomax opened this issue Nov 17, 2021 · 0 comments · Fixed by #7885

Assignees

Contributor

Pomax commented Nov 17, 2021 •

edited

Loading

load product page without CSRF token so that it's the same content for all users
make the voting JS fetch the token from a dedicated CSRF endpoint on the server.
then add that into the vote POST instead of querying the DOM for it.

this will allow us to cache-excempt the CSRF endpoint, without PNI product pages breaking the caching.

Pomax self-assigned this

Pomax mentioned this issue

take CSRF out of the page template for PNI products #7885

Merged

Pomax closed this as completed in #7885

data-sync-user mentioned this issue

Bump pillow from 10.2.0 to 10.3.0 #12138

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment