Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Distribution channel name in metrics is null after Glean updates. #3129

Closed
daoshengmu opened this issue Apr 7, 2020 · 3 comments · Fixed by #3130
Closed

Distribution channel name in metrics is null after Glean updates. #3129

daoshengmu opened this issue Apr 7, 2020 · 3 comments · Fixed by #3130
Assignees
Labels
bug This issue is a software or functional defect in progress regression
Milestone

Comments

@daoshengmu
Copy link
Contributor

Configuration

Firefox Reality version: v.10
Firefox Reality build ID:

Hardware:
All devices

Steps to Reproduce

  1. Watch the telemetry query from https://sql.telemetry.mozilla.org/queries/69899/source#176133,
    we can see the distribution_channel_name in metrics would be null sometimes.

Current Behavior

After FxR v.9, the distribution_channel_name would be null from some situations. I think it causes by the recent Glean updates.

Expected Behavior

distribution_channel_name should be according to BuildConfig.FLAVOR_platform.

Possible Solution

After discussion with Glean team, they suggest us setting metrics after Glean.Initialize(). Otherwise, those pings and operations will be deleted in some cases.

@daoshengmu daoshengmu self-assigned this Apr 7, 2020
@daoshengmu daoshengmu added bug This issue is a software or functional defect regression labels Apr 7, 2020
@daoshengmu daoshengmu added this to the #10 features milestone Apr 7, 2020
@daoshengmu daoshengmu reopened this Apr 9, 2020
@daoshengmu daoshengmu modified the milestones: #10 features, #11 polish Apr 9, 2020
@daoshengmu
Copy link
Contributor Author

It needs to update GV for the newest version of Glean. Let's move it to v.11

@bluemarvin
Copy link
Contributor

@daoshengmu Is this fixed in v11 or should it be moved to v12?

@daoshengmu
Copy link
Contributor Author

Fixed by #3384

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a software or functional defect in progress regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants