You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
daoshengmu
changed the title
Tab opened metric labels are _other_ in the table
Tab opened and FxA received_tab metric labels are _other_ in the table
Apr 22, 2020
Actually, our GleanMetricsServiceTest can help us catch this bug if we follow the new version of Glean. I can see running failures once doing a new update.
Configuration
Firefox Reality version:
Firefox Reality build ID: v.10
Hardware:
All the devices
Steps to Reproduce
Current Behavior
We are using TabSource.name() and DeviceType.name(), it will return uppercase letters. According to Glean doc [1], it is not allowed.
[1] https://mozilla.github.io/glean/book/user/metrics/labeled_counters.html#limits
Expected Behavior
The fields in our metric table should have keys and values instead of a
_other_
.Possible Solution
We should
toLowerCase()
it and give unit tests to prevent this kind of issue be happened again.The text was updated successfully, but these errors were encountered: