Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Tab opened and FxA received_tab metric labels are _other_ in the table #3212

Closed
daoshengmu opened this issue Apr 22, 2020 · 1 comment · Fixed by #3384
Closed

Tab opened and FxA received_tab metric labels are _other_ in the table #3212

daoshengmu opened this issue Apr 22, 2020 · 1 comment · Fixed by #3384
Assignees
Milestone

Comments

@daoshengmu
Copy link
Contributor

daoshengmu commented Apr 22, 2020

Configuration

Firefox Reality version:
Firefox Reality build ID: v.10

Hardware:
All the devices

Steps to Reproduce

  1. Visit https://sql.telemetry.mozilla.org/queries/70315/source

Current Behavior

We are using TabSource.name() and DeviceType.name(), it will return uppercase letters. According to Glean doc [1], it is not allowed.

[1] https://mozilla.github.io/glean/book/user/metrics/labeled_counters.html#limits

Expected Behavior

The fields in our metric table should have keys and values instead of a _other_.

Possible Solution

We should toLowerCase() it and give unit tests to prevent this kind of issue be happened again.

@daoshengmu daoshengmu self-assigned this Apr 22, 2020
@daoshengmu daoshengmu changed the title Tab opened metric labels are _other_ in the table Tab opened and FxA received_tab metric labels are _other_ in the table Apr 22, 2020
@daoshengmu daoshengmu added this to the #11 polish milestone Apr 24, 2020
@daoshengmu
Copy link
Contributor Author

Actually, our GleanMetricsServiceTest can help us catch this bug if we follow the new version of Glean. I can see running failures once doing a new update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant