From 0f8fbab3f842df2a8bf256e018fd095df6ef0832 Mon Sep 17 00:00:00 2001 From: Yunfei Li Date: Wed, 21 Jun 2023 15:22:52 +0200 Subject: [PATCH] fix: when enable strictTemplates, incorrect types error on boolean input value --- projects/ngx-scrollbar-demo/tsconfig.app.json | 8 +++++++- projects/ngx-scrollbar/src/lib/ng-scrollbar.ts | 12 ++++++------ 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/projects/ngx-scrollbar-demo/tsconfig.app.json b/projects/ngx-scrollbar-demo/tsconfig.app.json index 809c09ca..d1fdcd77 100644 --- a/projects/ngx-scrollbar-demo/tsconfig.app.json +++ b/projects/ngx-scrollbar-demo/tsconfig.app.json @@ -10,5 +10,11 @@ ], "include": [ "src/**/*.d.ts" - ] + ], + "angularCompilerOptions": { + "enableI18nLegacyMessageIdFormat": false, + "strictInjectionParameters": true, + "strictInputAccessModifiers": true, + "strictTemplates": true + } } diff --git a/projects/ngx-scrollbar/src/lib/ng-scrollbar.ts b/projects/ngx-scrollbar/src/lib/ng-scrollbar.ts index af7d3cda..2d233c3a 100644 --- a/projects/ngx-scrollbar/src/lib/ng-scrollbar.ts +++ b/projects/ngx-scrollbar/src/lib/ng-scrollbar.ts @@ -56,7 +56,7 @@ export class NgScrollbar implements OnInit, OnChanges, AfterViewInit, OnDestroy return this._disabled; } - set disabled(disabled: boolean) { + set disabled(disabled: boolean | string) { this._disabled = coerceBooleanProperty(disabled); } @@ -66,7 +66,7 @@ export class NgScrollbar implements OnInit, OnChanges, AfterViewInit, OnDestroy return this._sensorDisabled; } - set sensorDisabled(disabled: boolean) { + set sensorDisabled(disabled: boolean | string) { this._sensorDisabled = coerceBooleanProperty(disabled); } @@ -76,7 +76,7 @@ export class NgScrollbar implements OnInit, OnChanges, AfterViewInit, OnDestroy return this._pointerEventsDisabled; } - set pointerEventsDisabled(disabled: boolean) { + set pointerEventsDisabled(disabled: boolean | string) { this._pointerEventsDisabled = coerceBooleanProperty(disabled); } @@ -86,7 +86,7 @@ export class NgScrollbar implements OnInit, OnChanges, AfterViewInit, OnDestroy return this._viewportPropagateMouseMove; } - set viewportPropagateMouseMove(disabled: boolean) { + set viewportPropagateMouseMove(disabled: boolean | string) { this._viewportPropagateMouseMove = coerceBooleanProperty(disabled); } @@ -96,7 +96,7 @@ export class NgScrollbar implements OnInit, OnChanges, AfterViewInit, OnDestroy return this._autoHeightDisabled; } - set autoHeightDisabled(disabled: boolean) { + set autoHeightDisabled(disabled: boolean | string) { this._autoHeightDisabled = coerceBooleanProperty(disabled); } @@ -106,7 +106,7 @@ export class NgScrollbar implements OnInit, OnChanges, AfterViewInit, OnDestroy return this._autoWidthDisabled; } - set autoWidthDisabled(disabled: boolean) { + set autoWidthDisabled(disabled: boolean | string) { this._autoWidthDisabled = coerceBooleanProperty(disabled); }